Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My intuition is that if the reader tries to
ReadInt
orReadLong
and it encounters anEOF
before the end of the int/long, then it should be an error. In that case, we should wrap theEOF
error.However, after this PR's change, two tests are failing:
TestDecoder_SkipRef
andTestDecoder_DecodeEOFDoesntReturnError
.Is my assumption correct? And in that case what should we do with these tests?